Preview viewer uses omero-web-zarr s3 data if available #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-moore
force-pushed
the
zarr_render_image
branch
from
74ed485 to
0f59226
Compare
for more information, see https://pre-commit.ci
|
Following discussion with IDR today, closing this for now since we want to make minimal changes for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental!
This corresponds to ome/omero-web-zarr#15.
In that
omero-web-zarrPR, we check whether OME-Zarr data is publicly accessible via s3 URL and if so then we can use that data for/zarr/render_image/doing the rendering in python omero-web code rather than using the server.In this PR, we test for the availability of the
omero-web-zarrplugin and the public s3 url, and if we have that then the Preview viewer uses/zarr/as thebase url.