Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right panel performance fixes #17

Closed
wants to merge 11 commits into from

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Sep 18, 2019

Port PR from ome/openmicroscopy#6075

This PR contains 2 approaches to improve right panel performance:

  • tries to reduce the times that conn.getExperimenter() is called for right panel - e.g. single P/D/I etc (see link above)
  • improves loading speed of batch-annotate panel (when multiple objects selected) by NOT loading the toolbar download menu until the user clicks on it. This was being very slow when many Images are selected (as in Query string ids #225) because the 'canDownloadAsJpg() to enable png/tiff/jpeg download was calling 'image.getSizeX() etc for every image (loading the pixels on the fly each time). To test, select multiple objects and test behaviour of the Download menu.

@snoopycrimecop
Copy link
Member

snoopycrimecop commented Sep 18, 2019

Conflicting PR. Removed from build OMERO-python-superbuild-push#16. See the console output for more details.
Possible conflicts:

--conflicts Conflict resolved in build OMERO-python-superbuild-push#43. See the console output for more details.

@snoopycrimecop
Copy link
Member

snoopycrimecop commented Sep 19, 2019

Conflicting PR. Removed from build OMERO-python-superbuild-push#17. See the console output for more details.
Possible conflicts:

--conflicts Conflict resolved in build OMERO-python-superbuild-push#18. See the console output for more details.

@snoopycrimecop
Copy link
Member

snoopycrimecop commented Sep 24, 2019

Conflicting PR. Removed from build OMERO-python-superbuild-push#22. See the console output for more details.
Possible conflicts:

--conflicts Conflict resolved in build OMERO-python-superbuild-push#24. See the console output for more details.

@snoopycrimecop
Copy link
Member

snoopycrimecop commented Sep 27, 2019

Conflicting PR. Removed from build OMERO-python-superbuild-push#14. See the console output for more details.
Possible conflicts:

--conflicts Conflict resolved in build OMERO-python-superbuild-push#57. See the console output for more details.

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-python-superbuild-push#59. See the console output for more details.
Possible conflicts:

--conflicts

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-python-superbuild-push#25. See the console output for more details.
Possible conflicts:

--conflicts

@snoopycrimecop
Copy link
Member

snoopycrimecop commented Sep 28, 2019

Conflicting PR. Removed from build OMERO-python-superbuild-push#15. See the console output for more details.
Possible conflicts:

--conflicts Conflict resolved in build OMERO-python-superbuild-push#1191. See the console output for more details.

@will-moore will-moore closed this Mar 6, 2020
@will-moore will-moore reopened this Sep 15, 2022
@will-moore will-moore closed this Sep 15, 2022
@will-moore will-moore reopened this Sep 15, 2022
@will-moore will-moore mentioned this pull request Sep 22, 2022
@jburel
Copy link
Member

jburel commented Jan 17, 2023

Excluding ahead of the dependencies upgrade work

EDIT (Will) - remove exclude 20th April

@will-moore
Copy link
Member Author

Need to create a lot of users on merge-ci to test. Created a group called many_users, then...

$ for i in {1..200}; do omero user add test-$i name-$i surname-$i many_users -P ome --ignore-existing; done

@will-moore
Copy link
Member Author

Removed "exclude" flag 9th Feb

@will-moore
Copy link
Member Author

Going to exclude from build temporarily, so we can check performance on merge-ci on groups with few or many users...

--exclude

@will-moore
Copy link
Member Author

Haven't been able to reproduce slow right-panel loading on merge-ci. Tricky to test.

@will-moore will-moore closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants