Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OMERO.web 5.27.0 #85

Closed
wants to merge 1 commit into from

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Aug 14, 2024

Fixes #84

The internal logic of omeroweb.webclient.tree._marshal_image has changed to support the archived status of the images. This change adjusts the mapr logic consuming this internal API accordingly and declares OMERO.web 5.27.0 as the minimal version

The internal logic of omeroweb.webclient.tree._marshal_image has
changed to support the archived status of the images. This change
adjusts the mapr logic consuming this internal API accordingly
and declares OMERO.web 5.27.0 as the minimal version
@sbesson sbesson requested a review from will-moore August 14, 2024 09:06
@sbesson sbesson closed this Aug 14, 2024
@sbesson sbesson reopened this Aug 14, 2024
@sbesson
Copy link
Member Author

sbesson commented Aug 14, 2024

The integration failures are likely unrelated to this build and point to the fact that jinja2 is required by the integration tests through the usage of the deprecated omero.util.populate_metadata module but is not installed as a dependency of omero-mapr.

I am not sure of when this regression was introduced but I cannot see an obvious mechanism for declaring a dependency within the test phase of https://github.com/ome/omero-test-infra. Immediate options I can think of are:

Other suggestions/ideas from omero-test-infra maintainers welcome /cc @joshmoore @jburel @will-moore

@sbesson
Copy link
Member Author

sbesson commented Aug 28, 2024

Closing as this workaround should be superseded by the work in ome/omero-web#577 and a probably upcoming release of OMERO.web restoring compatiblity.

As discussed in ome/omero-web#577 (comment), this application is tightly coupled to the omeroweb.webclient module which deviates from the recommendation established in ome/omero-documentation#1378. This means this app is particularly prone to any change made to the upstream Webclient. Its logic should probably be audited as this might inform which aspects of the webclient could be reasonably exposed as public API for downstreams apps to consume.

@sbesson sbesson closed this Aug 28, 2024
@dominikl
Copy link
Member

I still get this error when I try to deploy a pilot with this PR included:

TASK [ome.iptables_raw : iptables-raw | enable iptables] **********************************************************************************************************
fatal: [19cd7a52-3664-4ed9-8c5f-f0b880e28221]: FAILED! => {"ansible_facts": {"discovered_interpreter_python": "/usr/bin/python3.9"}, "changed": false, "msg": "Unable to start service iptables: Job for iptables.service failed because the control process exited with error code.\nSee \"systemctl status iptables.service\" and \"journalctl -xeu iptables.service\" for details.\n"}

@pwalczysko pwalczysko mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archived status in _marshal_image()
2 participants