-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter owners and groups dropdown lists #592
base: master
Are you sure you want to change the base?
Conversation
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/omero-figure-filtering-users-by-group/101933/2 |
@JensWendt would you be able to give this a test? Thanks! |
Hey @will-moore yes I will. Promised. |
eeeehhhmm, stupid question, but.... where do I find |
@will-moore *Bump |
@JensWendt Do you have a local omero-web dev environment? I thought you would have done for #589 ?
That will compile the JS and copy it to the installed app |
Okay, that is what I lowkey feared :/ |
I tried it, filtering figures on the production server is much smoother. After File → Open If I look to filter per User, it lists all users of my OMERO. That's a lot, but expected (there's no filter on the group yet) ✅ (no change) If I look to filter per Group, it only shows me the group I'm part of ✅ (change for admin user) After filtering per Group, I now only see in Users the users of that group. ✅ (change for all) As an admin, if I want to check a figure from a group I'm not part of, I have for the Users to select first "Show all". Then I would see all groups listed. This PR makes it less intuitive for admins to search for a figure of a group (is it an issue? i don't know) 🟧 Could the groups be listed for admins like on the main OMERO.web page ? Group you belong to first, then all groups? |
See https://forum.image.sc/t/omero-figure-filtering-users-by-group/101933
When you filter the File > Open list by a Group, the owners list is also filtered to only show Owners within that Group.
When you filter the files by Owner, the groups list is also filtered to only show Groups for that Owner.
So, now it shouldn't be possible to filter by a Group / Owner combination that filters out ALL files.
Also, the currently selected group & owner is indicated by a tick: