Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter owners and groups dropdown lists #592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

will-moore
Copy link
Member

See https://forum.image.sc/t/omero-figure-filtering-users-by-group/101933

When you filter the File > Open list by a Group, the owners list is also filtered to only show Owners within that Group.
When you filter the files by Owner, the groups list is also filtered to only show Groups for that Owner.

So, now it shouldn't be possible to filter by a Group / Owner combination that filters out ALL files.

Also, the currently selected group & owner is indicated by a tick:

Screenshot 2024-09-23 at 12 21 51

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omero-figure-filtering-users-by-group/101933/2

@will-moore
Copy link
Member Author

@JensWendt would you be able to give this a test? Thanks!

@JensWendt
Copy link
Contributor

Hey @will-moore yes I will. Promised.
But I am swamped right now and did not find the time yet.
I will bump it higher on my prio-list

@JensWendt
Copy link
Contributor

JensWendt commented Oct 8, 2024

eeeehhhmm, stupid question, but.... where do I find files.js in the OMERO.web directory hierarchy to swap it with your adapted one?

@JensWendt
Copy link
Contributor

JensWendt commented Oct 29, 2024

@will-moore *Bump
Would love to test it, but have no idea how to get the changed code onto my test-server ?!

@will-moore
Copy link
Member Author

@JensWendt Do you have a local omero-web dev environment? I thought you would have done for #589 ?
If so, and you have this app installed there pip install -e ., then to include the JS changes, you need to have https://nodejs.org/ installed.
Then you can do:

cd omero_figure
npm install 
npm run build

That will compile the JS and copy it to the installed app static directory.

@JensWendt
Copy link
Contributor

Okay, that is what I lowkey feared :/
Nope, I do not have a dev environment. For #589 I just changed the lines in the "live" .py file and tried it out.
To be honest I cannot promise you a time frame when I come around to work my way into setting this up.
If you guys have a dev environment set up and ready to go, you might be faster with just creating some figures for different users and try it out that way.
And here I was, naively hoping Javascript stuff would not need a compile step 😩

@Tom-TBT
Copy link
Contributor

Tom-TBT commented Nov 20, 2024

I tried it, filtering figures on the production server is much smoother.

After File → Open
I get list of my all my figures in different groups. ✅ (no change)

If I look to filter per User, it lists all users of my OMERO. That's a lot, but expected (there's no filter on the group yet) ✅ (no change)

If I look to filter per Group, it only shows me the group I'm part of ✅ (change for admin user)

After filtering per Group, I now only see in Users the users of that group. ✅ (change for all)

As an admin, if I want to check a figure from a group I'm not part of, I have for the Users to select first "Show all". Then I would see all groups listed. This PR makes it less intuitive for admins to search for a figure of a group (is it an issue? i don't know) 🟧

Could the groups be listed for admins like on the main OMERO.web page ? Group you belong to first, then all groups?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants