Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy from tests_require in setup.py #568

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

will-moore
Copy link
Member

This removes the listing of numpy in test dependencies, which shouldn't be needed as numpy is already a dependency of omero-py. Seb noticed that we list numpy as a dependency as part of his work at ome/omero-py#414.

It was added in #356 due to E ModuleNotFoundError: No module named 'numpy' but not sure why/where that was seen...

@snoopycrimecop
Copy link
Member

snoopycrimecop commented Jun 18, 2024

Conflicting PR. Removed from build OMERO-plugins-push#99. See the console output for more details.
Possible conflicts:

--conflicts Conflict resolved in build OMERO-plugins-push#100. See the console output for more details.

@jburel jburel mentioned this pull request Jun 18, 2024
@will-moore will-moore requested a review from jburel July 11, 2024 09:13
@will-moore will-moore merged commit 3bad815 into ome:master Oct 3, 2024
1 check passed
@will-moore will-moore added this to the 7.2.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants