Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points in shape editor #555

Merged
merged 11 commits into from
Oct 4, 2024
Merged

Points in shape editor #555

merged 11 commits into from
Oct 4, 2024

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Apr 25, 2024

NB: this is on top of Vite PR #477 - needs to be merged first.

As discussed at ome/omero-iviewer#465 (comment), need to support Points in OMERO.figure.

Points were already supported in Figure_To_Pdf.py.

To test:

  • Add Points from OMERO
  • Draw, update (drag, change colour, line thickness), copy & paste Points
  • Save Points to the Figure - open Figure to check they are correct
  • Export Figure to PDF and to TIFF

@pwalczysko
Copy link
Member

Tested as per header of PR. lgtm

@will-moore
Copy link
Member Author

@jburel OK to merge this?

Testing workflow:

Drew Points (and Polygons) on image in iviewer
Open image in Figure - Add ROIs.
Select Points from OMERO
Draw new Points
Edit Points (colour, position, line thickness)
Export Figure to PDF and TIFF:

Screenshot 2024-08-30 at 14 19 42

@snoopycrimecop snoopycrimecop mentioned this pull request Aug 31, 2024
@jburel jburel self-requested a review September 6, 2024 12:09
@jburel
Copy link
Member

jburel commented Sep 6, 2024

note: we need to archive npm

@jburel
Copy link
Member

jburel commented Sep 13, 2024

@will-moore as general rule, it will be good to have a file with licenses associated to the icons used
see for example https://github.com/ome/openmicroscopy/blob/develop/lib/licenses/README
(t
This should now be moved to insight (this was pre-split)

@will-moore
Copy link
Member Author

The new icon here was copied from iviewer.
Most icons used in figure are from https://github.com/twbs/icons (MIT license).

@jburel
Copy link
Member

jburel commented Sep 13, 2024

That should be stated in a file

@will-moore will-moore mentioned this pull request Sep 13, 2024
@will-moore
Copy link
Member Author

Opened a PR at #587 to update licenses.txt.

@will-moore will-moore added this to the 7.2.0 milestone Oct 3, 2024
@jburel
Copy link
Member

jburel commented Oct 4, 2024

Has the last commit been tested?

@jburel
Copy link
Member

jburel commented Oct 4, 2024

@will-moore #577 conflicts with this PR, will you sort it?
Also having the code style matching in #577 (Spaces etc.) will be good to have

@pwalczysko
Copy link
Member

Tested as per #555 (comment) - works fine.

@will-moore
Copy link
Member Author

Thanks - yes, we can sort out conflicts and formatting with #577 once this is in

@jburel jburel merged commit 1c0e5f9 into ome:master Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants