-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Points in shape editor #555
Conversation
Tested as per header of PR. lgtm |
@jburel OK to merge this? Testing workflow: Drew Points (and Polygons) on image in iviewer |
note: we need to archive npm |
@will-moore as general rule, it will be good to have a file with licenses associated to the icons used |
The new icon here was copied from iviewer. |
That should be stated in a file |
Opened a PR at #587 to update licenses.txt. |
Has the last commit been tested? |
@will-moore #577 conflicts with this PR, will you sort it? |
Tested as per #555 (comment) - works fine. |
Thanks - yes, we can sort out conflicts and formatting with #577 once this is in |
NB: this is on top of Vite PR #477 - needs to be merged first.
As discussed at ome/omero-iviewer#465 (comment), need to support Points in OMERO.figure.
Points were already supported in
Figure_To_Pdf.py
.To test: