Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python-future compatibility code #23

Merged
merged 15 commits into from
May 8, 2024
Merged

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jan 24, 2024

See ome/omero-py#390 for the rationale

The list of changes should be identical i.e.:

  • all future or past import are replaced by Python 3 calls
  • all unnecessary builtins imports are removed
  • all Python 2 compatibility logic are removed
  • the unmaintained Dockerfile is removed

@sbesson sbesson requested review from joshmoore and jburel January 24, 2024 08:41
@sbesson
Copy link
Member Author

sbesson commented Feb 22, 2024

Following the release of OMERO.py 5.19.0 (thanks @pwalczysko), the last commits update this PR to also test omero-dropbox on Python 3.12 and update the GitHub actions to Node.js 20

@jburel
Copy link
Member

jburel commented Feb 23, 2024

The docker file has been removed. This could be updated. This has been done is other repository e.g. openmicroscopy

@sbesson
Copy link
Member Author

sbesson commented Feb 23, 2024

The docker file has been removed. This could be updated. This has been done is other repository e.g. openmicroscopy

I don't mind either way but unlike openmicroscopy I don't think this file was consumed by anything at least in terms of CI. Do you have recommendations guidelines on the target operating system or what the Docker image should be doing?

@jburel
Copy link
Member

jburel commented Feb 23, 2024

i am certainly not using it. If anyone using it for testing purpose, we can upgrade otherwise I won't bother
@joshmoore are you using the dockerfile?

@joshmoore
Copy link
Member

I assume the last usage was via .travis.yml.

@jburel
Copy link
Member

jburel commented Feb 23, 2024

In that case, let's remove it.

@sbesson
Copy link
Member Author

sbesson commented May 7, 2024

Is this in scope for the upcoming OMERO 5.6.11 release?

@jburel jburel merged commit 7f7352e into ome:master May 8, 2024
6 checks passed
@sbesson sbesson deleted the future_removal branch May 8, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants