Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blobs request #350

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Robert-Steiner
Copy link

@Robert-Steiner Robert-Steiner commented Nov 29, 2024

The blobs request fails with invalid digest format because sha256: is added twice in lines 557 and 560.

This PR removes the extra sha256: in line 560.

@Robert-Steiner Robert-Steiner changed the title Fix blob request Fix blobs request Nov 29, 2024
@Robert-Steiner Robert-Steiner marked this pull request as draft November 29, 2024 19:51
@Robert-Steiner Robert-Steiner marked this pull request as ready for review November 29, 2024 20:27
@ParthSareen
Copy link
Contributor

Hey @Robert-Steiner! Thanks for this! Could you also add a test to ensure this behavior is good? Thanks :)

@ParthSareen ParthSareen self-assigned this Nov 30, 2024
@Robert-Steiner
Copy link
Author

Hey @ParthSareen,
I updated the create_blob tests to verify that the digest has the correct format. Let me know what you think :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants