refactor: replace duplicate Regex

olivierdagenais · Sep 6, 2024 · ded290d · ded290d
1 parent 4c71d4f
commit ded290d
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/parsers/Bitbucket.ts b/src/parsers/Bitbucket.ts
@@ -10,8 +10,6 @@ const commitListUrlRegex = /commits\?until=(?<ref>[^&]+)(&.+)?/;
 const deepCommitUrlRegex =
     /commits\/(?<ref>[^#]+)(#(?<path>[^?]+)(\?[ft]=(?<lineNumber>\d+))?)?/;
 const prUrlRegex = /pull-requests\/(?<prId>\d+)(\/(?<extra>.*))?/;
-const prExtraRegex =
-    /commits\/(?<ref>[^#]+)(#(?<path>[^?]+)(\?[ft]=(?<lineNumber>\d+))?)?/;
 
 export class Bitbucket extends AbstractParser {
     parseLink(doc: Document, url: string): Link | null {
@@ -201,7 +199,7 @@ export class Bitbucket extends AbstractParser {
         const summary = h2Element.textContent;
         var prefix = "";
         if (extra) {
-            const prExtraMatch = extra.match(prExtraRegex);
+            const prExtraMatch = extra.match(deepCommitUrlRegex);
             if (prExtraMatch && prExtraMatch.groups) {
                 const prExtraGroups = prExtraMatch.groups;
                 prefix = this.prefixForLinePathCommit(prExtraGroups);