Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

fix uncle blokcs are orphaned #1574

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix uncle blokcs are orphaned #1574

wants to merge 2 commits into from

Conversation

yq0810
Copy link

@yq0810 yq0810 commented Jan 3, 2023

From the perspective of the integrity of the program code, conitnue is missing when confirming the uncle block, which leads to the wrong entry of if block.ConfirmationProgress > 0.75 , cause uncle blocks to become orphan blocks

fix  uncle blokcs are orphaned when block.ConfirmationProgress > 0.75
@oliverw
Copy link
Owner

oliverw commented Jan 31, 2023

As I currently do not have an ETC pool, could someone comment on how effective this fix is?

@jon4hz
Copy link
Contributor

jon4hz commented Feb 1, 2023

I think the logic makes sense, even though I never encountered that issue. But maybe I just got lucky.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants