Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat): Error if changing adapter in empty chat w/o system prompt. #616

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix(chat): Error if changing adapter in empty chat w/o system prompt. #616

merged 1 commit into from
Jan 8, 2025

Conversation

schilkp
Copy link
Contributor

@schilkp schilkp commented Jan 8, 2025

Description

Fixes a small bug where changing adapter does not work if in am empty chat with system prompt disabled.

Repor:

  • nvim --clean -u minimal.lua
  • :CodeCompanioChat
  • gs (remove system prompt)
  • Try changing adapter with ga

Screenshots

With and without change:

before_and_after.mp4

Checklist

  • I've read the CONTRIBUTING guidelines and have adhered to them in this PR
  • I've updated the README
  • I've ran the make docs command

@olimorris
Copy link
Owner

Great spot, thank you!

@olimorris olimorris merged commit 3e64e6c into olimorris:main Jan 8, 2025
3 checks passed
@schilkp schilkp deleted the schilkp/fix_adatper_chng branch January 8, 2025 13:53
@olimorris olimorris mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schilkp @olimorris