Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.stylelintignore is not respected #85

Open
luboskmetko opened this issue Jul 26, 2017 · 4 comments
Open

.stylelintignore is not respected #85

luboskmetko opened this issue Jul 26, 2017 · 4 comments
Labels

Comments

@luboskmetko
Copy link

luboskmetko commented Jul 26, 2017

First of all, thanks for the plugin, we are using it in our Yeoman generator.

Recently after updating to 4.0.0 version in generated projects, it seems that gulp-stylelint stopped respecting .stylelintignore we use in those projects.

Was wondering if it has something to do with stylelint update to v8.0.0, but when I run stylelint CLI on a project, it respects .stylelintignore

Thanks

@olegskl
Copy link
Owner

olegskl commented Jul 26, 2017

Hmm. Thanks for opening this issue. In fact, I'm surprised it worked before. Stylelint ignores files only when running a glob search itself. But gulp-stylelint pipes file data directly into stylelint based on what you pass to gulp.src, so stylelint just blindly accepts everything.

It seems that gulp-stylelint will need to read .stylelintignore and ignore some files that piped through. This is quite a side-effect...

@olegskl olegskl added the bug label Jul 26, 2017
@luboskmetko
Copy link
Author

It worked with v3.9.0, I've created a test case for it https://github.com/luboskmetko/test-gulp-stylelint

They introduced some .stylelintignore changes here stylelint/stylelint#2464, cannot it be related?

@Bigdragon13th
Copy link

I'm facing the same issue, any update?

@faragos
Copy link

faragos commented Jun 19, 2020

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants