Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Volcanic Ore Pack & fix errors with 2.4.0 osjs #5709

Merged
merged 18 commits into from
Feb 27, 2024

Conversation

nwjgit
Copy link
Contributor

@nwjgit nwjgit commented Feb 21, 2024

Description:

Adds Volcanic ore pack to volcanic mine buyable.
Follow up from: oldschoolgg/oldschooljs#356
Ore Pack & error fixing for 2.4.0 are in this single PR due to being dependent on each other.

Changes:

  • Add item aliases to both ore packs to prevent item mismatch
  • Add bank text to distinguish the packs since they use the same sprite
  • Update giant's foundry ore pack to give the proper pack
  • Add Ore pack to volcanic mine shop
  • Add broken dragon pickaxe to volcanic mine cl
  • Update osjs to 2.4.0
    • Remove Blighted bind sack & Blighted snare sack due to being removed from game and causing issues with 2.4.0 from starting properly.
    • Updated team-cape price and various ironman prices to prevent price abusing with buy and sacrifice: Bucket, Steel pickaxe, Adamant halberd, Berserker helm
    • Update util.test to fix an issue. "A yellow square" is now "Yellow square"
    • Update Sacrifice.test to reflect new prices

Other checks:

@nwjgit nwjgit changed the title Add Volcanic Ore Pack Add Volcanic Ore Pack & fix errors with 2.4.0 osjs Feb 21, 2024
@nwjgit nwjgit force-pushed the VolcanicMineOrePack branch from c2b6ad2 to 559e047 Compare February 21, 2024 21:32
@nwjgit nwjgit force-pushed the VolcanicMineOrePack branch from 1fbb949 to ca15dbe Compare February 22, 2024 14:59
@gc gc merged commit c105a2f into oldschoolgg:master Feb 27, 2024
5 checks passed
@nwjgit nwjgit deleted the VolcanicMineOrePack branch March 2, 2024 06:26
@TastyPumPum TastyPumPum mentioned this pull request Mar 11, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add broken dragon pickaxe to Volcanic Mine
3 participants