Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the wasmHelperABI #145

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

update the wasmHelperABI #145

wants to merge 2 commits into from

Conversation

lyh169
Copy link
Contributor

@lyh169 lyh169 commented May 23, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

Codecov Report

Merging #145 (7e12010) into dev (9c0b8c0) will not change coverage.
The diff coverage is n/a.

❗ Current head 7e12010 differs from pull request most recent head 00184e2. Consider uploading reports for the commit 00184e2 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev     #145   +/-   ##
=======================================
  Coverage   34.22%   34.22%           
=======================================
  Files         423      423           
  Lines       44331    44331           
=======================================
  Hits        15173    15173           
  Misses      28057    28057           
  Partials     1101     1101           
Impacted Files Coverage Δ
app/rpc/namespaces/eth/wasm.go 2.20% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants