Merge pull request #598 from okex/fix-precision-error

fix precision error during refund gas
okx · Jan 26, 2021 · ed53308 · ed53308
2 parents fbd5a75 + 1aaeb0c
commit ed53308
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/x/evm/handler_test.go b/x/evm/handler_test.go
@@ -4,12 +4,13 @@ import (
 	"crypto/ecdsa"
 	"encoding/json"
 	"fmt"
-	"github.com/cosmos/cosmos-sdk/x/supply"
 	"math/big"
 	"strings"
 	"testing"
 	"time"
 
+	"github.com/cosmos/cosmos-sdk/x/supply"
+
 	"github.com/status-im/keycard-go/hexutils"
 
 	"github.com/stretchr/testify/suite"
@@ -639,7 +640,7 @@ func (suite *EvmTestSuite) TestRefundGas() {
 			balanceAfterHandler := big.NewInt(1).Sub(userBalance, tc.consumed)
 			balanceAfterRefund := suite.app.EvmKeeper.GetBalance(suite.ctx, sender)
 
-			suite.Require().Equal(big.NewInt(1).Mul(gasRefund, big.NewInt(1000000000000000000)), big.NewInt(1).Sub(balanceAfterRefund, balanceAfterHandler))
+			suite.Require().Equal(big.NewInt(1).Mul(gasRefund, big.NewInt(1)), big.NewInt(1).Sub(balanceAfterRefund, balanceAfterHandler))
 		})
 	}
-}
+}
diff --git a/x/evm/types/state_transition.go b/x/evm/types/state_transition.go
@@ -3,10 +3,11 @@ package types
 import (
 	"errors"
 	"fmt"
-	"github.com/cosmos/cosmos-sdk/x/auth/types"
 	"math/big"
 	"strings"
 
+	"github.com/cosmos/cosmos-sdk/x/auth/types"
+
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/core"
 	ethtypes "github.com/ethereum/go-ethereum/core/types"
@@ -309,7 +310,7 @@ func (st StateTransition) RefundGas(ctx sdk.Context) error {
 		ctx.WithGasMeter(sdk.NewInfiniteGasMeter()),
 		types.FeeCollectorName,
 		senderAddress,
-		sdk.NewCoins(sdk.NewCoin(st.CoinDenom, sdk.NewIntFromBigInt(feeReturn))),
+		sdk.NewCoins(sdk.NewCoin(st.CoinDenom, sdk.NewDecFromBigIntWithPrec(feeReturn, sdk.Precision))),
 	); err != nil {
 		return err
 	}