Added controller-gen installation in the golang image #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nacho Fuertes <[email protected]>
ifbyol
requested review from
pchico83,
rberrelleza and
rlamana
as code owners
pchico83
approved these changes
Nov 18, 2024
andreafalzetti
approved these changes
Nov 18, 2024
|
Change LG, but CI is failing |
…e by build arg to avoid issues with 1.20 and 1.21 versions of golang Signed-off-by: Nacho Fuertes <[email protected]>
Yeah, the job takes a lot of time and some commands fail with transient errors. I had also to make configurable the dependency version as latest available version doesn't work with older versions of golang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install controller-get go dependency to have it available in our golang dev containers