Skip to content

Commit

Permalink
Add support to Node 20 (#110)
Browse files Browse the repository at this point in the history
* add node 20 image

* remove old node images

* fix ruby bundler version incompatibility
  • Loading branch information
bgonp authored Jan 25, 2024
1 parent cf6b203 commit bfca696
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 15 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ The development containers on this list are maintained by the Okteto team to hel
| golang 1.21 | [okteto/golang:1](golang/Dockerfile) |
| jdk 17, Gradle 8.2 | [okteto/gradle:6.5](gradle/Dockerfile) |
| jdk 17, Maven 3 | [okteto/maven:3-openjdk](maven/Dockerfile) |
| node 18 | [okteto/node:18](node/Dockerfile) |
| node 20 | [okteto/node:20](node/Dockerfile) |
| php 7 | [okteto/php:7](php/Dockerfile) |
| python 3 | [okteto/python:3](python/Dockerfile) |
| ruby 2 | [okteto/ruby:2](ruby/Dockerfile) |
Expand Down
19 changes: 6 additions & 13 deletions docker-compose.node.yml
Original file line number Diff line number Diff line change
@@ -1,24 +1,17 @@
version: '3.7'

services:
node18:
image: okteto/node:18
build:
context: .
dockerfile: node/Dockerfile
args:
VERSION: 18
node16:
image: okteto/node:16
node20:
image: okteto/node:20
build:
context: .
dockerfile: node/Dockerfile
args:
VERSION: 16
node14:
image: okteto/node:14
VERSION: 20
node18:
image: okteto/node:18
build:
context: .
dockerfile: node/Dockerfile
args:
VERSION: 14
VERSION: 18
3 changes: 2 additions & 1 deletion ruby/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ WORKDIR /usr/src/app
# setup okteto message
COPY bashrc /root/.bashrc

RUN gem install bundler
# TODO: Forcing bundler version because v2.4.22 was the last one to support ruby v2. We should remove this once we upgrade to ruby v3
RUN gem install bundler -v 2.4.22

CMD ["bash"]

0 comments on commit bfca696

Please sign in to comment.