This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 70
Types and improvements #62
Open
ctrl-f5
wants to merge
3
commits into
okta:develop
Choose a base branch
from
ctrl-f5:types-and-improvements
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #62 +/- ##
==============================================
+ Coverage 33.77% 92.85% +59.07%
- Complexity 98 110 +12
==============================================
Files 9 10 +1
Lines 225 238 +13
==============================================
+ Hits 76 221 +145
+ Misses 149 17 -132
Continue to review full report at Codecov.
|
Thank you for the PR, we would need to have you sign a cla for this to be merged in after we do our internal review. You can begin the cla process now by visiting developer.okta.com/cla |
ctrl-f5
force-pushed
the
types-and-improvements
branch
from
November 17, 2020 22:29
6449d31
to
b9f37ac
Compare
ctrl-f5
force-pushed
the
types-and-improvements
branch
from
November 18, 2020 08:51
b9f37ac
to
3c06483
Compare
I have sent in the CLA, not sure how it will be linked to my github account though |
Thanks @ctrl-f5 we manage the CLA's externally right now. I see the CLA and will add this PR to our tasks to look at and possibly be merged in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on #61 and adds some additional improvements. Separated in a new PR because they are not all BC (if people have extended classes they must also add the new type info).
DiscoveryMethodInterface
toDiscoveryMethod
analog to howAdaptor
is set upif
andforeach