#2342 - bypassUI: true option in group-large.spec.js and etc.
#2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-income
|
||||||||||||||||||||||||
| Project |
group-income
|
| Run status |
|
| Run duration | 08m 36s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
SebinSong
changed the title
bypassUI: true option in group-large.spec.js and etc.bypassUI: true option in group-large.spec.js and etc.
|
it appears that adding [Before] 
[After] 
Another attempt: 
|
taoeffect
reviewed
Oct 15, 2024
Comment on lines
-27
to
-29
| if (i > 3) { | ||
| cy.getByDT('contributionsLink').click() | ||
| } |
There was a problem hiding this comment.
Why was this logic removed? 🤔
There was a problem hiding this comment.
Now that we use cy.giAddRandomIncome({ bypassUI: true }) right below it, it's not necessary to navigate to the /contributions page at this point in the flow.
taoeffect
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Very cool, nicely done @SebinSong!
And I see you remembered to save at least some cy.giLogout() tests - nice!
One question...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2342
Currently
group-large.spec.jstest-suite has relatively high number of repeated action such as, 'A group with 12 members shows correctly the pledging month overview widget' etc. The goal of this PR is to reduce the duration of this test by implementingbypassUI: trueoptions for those repeated actions, which arecy.giAddRandomIncome()cy.giLogout()This lead to below improvement when tested locally on my Mac OS.
[Tested in
master][After update]
while at it,
cy.giLogout({ bypassUI: true })has been added in other*.spec.jsfiles.