#2374 Fix typos in various places #2376
Open
+28
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-income
|
||||||||||||||||||||||||
| Project |
group-income
|
| Run status |
|
| Run duration | 09m 30s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
|
I found another place for a typo so made a fix for that too: 
|
taoeffect
reviewed
Oct 14, 2024
frontend/views/pages/GroupChat.vue
Outdated
| data-test='channelMembers' | ||
| ) {numMembers} members | ||
| ) | ||
| i18n(v-if='summary.numberOfMembers === 1' :args='{ num: summary.numberOfMembers }') {num} member |
There was a problem hiding this comment.
In this case, there's no need for the {num} variable in the string or the :args :), you know it's 1
There was a problem hiding this comment.
Right, it's a good point.
taoeffect
reviewed
Oct 14, 2024
frontend/views/pages/Payments.vue
Outdated
| const args = { amt: this.withGroupCurrency(amount), count: membersLen } | ||
|
|
||
| return membersLen === 1 | ||
| ? L('{amt} in total, to {count} member', args) |
There was a problem hiding this comment.
Same here, can remove {count}
taoeffect
reviewed
Oct 14, 2024
Comment on lines
160
to
164
| ? L('You and {count} other member are contributing.', { count }) | ||
| : L('You and {count} other members are contributing.', { count }) | ||
| : isSingularCount | ||
| ? L('{count} member is contributing.', { count }) | ||
| : L('{count} members are contributing.', { count }) |
taoeffect
requested changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2374
[ Some screenshots for the fixes ]