[osh/cmd_parse] Produce a more useful error message if a dangling do is detected #1570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experimenting with producing error messages that try to guess at the user's intent and then produce more specific error messages. In this pr, I've added specific error messaging for errors like the following:
Before my changes we get the following error message:
With my changes:
This PR is more of a proof-of-concept, a more thought out PR might generalize this check to while loops.