feat: use Pydantic to define CAF class #96
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, this PR was going to use the initial
ga4gh.va_specpackage that Kori just pushed a 0.1.0 release for -- but it sounds like we want to hold off on that, because it includes changes to the models not yet implemented in other sources like gnomAD. However, I think it'd still be wise to port the CAF object from a dict to a Pydantic class for the sake of less API chafe when we do make the move in the future (and so that my initial work on this doesn't totally go to waste).Unfortunately, we still haven't gotten access to the new data on AnVIL used in the tests, so I haven't run them locally, but I... think they should pass? Can keep this in draft until then, though.