Fix Issue 119 #47
Merged
Fix Issue 119 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: At claimDefaulted, the lender may not receive the token because the Unclaimed token is not processed Issue Link: sherlock-audit/2023-08-cooler-judging#119 Fix Description: Set amount and collateral to zero but do not delete loan struct.
|
Why does the loan structure get deleted in claimRepaid but not in claimDefaulted? |
|
i think only the unclaimed field of the loan struct gets deleted in claimRepaid. I didn't write that and thought it was weird vs setting it to zero but assumed it was a gas optimization thing. It should not be deleting the entire struct. |
|
it is what zeus mentions, this code is only clearing the unclaimed variable of the struct. We could set it to |
This was referenced Sep 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: At claimDefaulted, the lender may not receive the token because the Unclaimed token is not processed
Issue Link: sherlock-audit/2023-08-cooler-judging#119
Fix Description: Set amount and collateral to zero but do not delete loan struct.