fix: no receivables update in extension

ohmzeus · Sep 16, 2023 · e95d313 · e95d313
1 parent d8d08e7
commit e95d313
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/Clearinghouse.sol b/src/Clearinghouse.sol
@@ -185,12 +185,8 @@ contract Clearinghouse is Policy, RolesConsumer, CoolerCallback {
         // Ensure Clearinghouse is the lender.
         if (loan.lender != address(this)) revert NotLender();
 
+        // Calculate extension interest based on remaining principal.
         uint256 interestBase = interestForLoan(loan.principal, loan.request.duration);
-        if (loan.interestDue != interestBase) {
-            // If interest has manually been repaid, receivables need to be updated
-            interestReceivables += interestBase - loan.interestDue;
-        }
-
         // Transfer in extension interest from the caller.
         dai.transferFrom(msg.sender, loan.recipient, interestBase * times_);
 

diff --git a/src/test/Clearinghouse.t.sol b/src/test/Clearinghouse.t.sol
@@ -391,7 +391,7 @@ contract ClearinghouseTest is Test {
         assertEq(extendedLoan.collateral, repaidLoan.collateral, "collateral");
         assertEq(extendedLoan.expiry, repaidLoan.expiry + repaidLoan.request.duration * times_, "expiry");
         // Check: clearinghouse storage
-        assertEq(clearinghouse.interestReceivables(), initInterest + initLoan.interestDue - repaidLoan.interestDue);
+        assertEq(clearinghouse.interestReceivables(), initInterest);
         assertEq(clearinghouse.principalReceivables(), initPrincipal);
     }