feat: Added Gradle plugin #625
Conversation
chriptus13
force-pushed
the
add-gradle-plugin
branch
from
b430b69
to
263934e
Compare
| @@ -0,0 +1,25 @@ | |||
| # Gradle plugin | |||
|
|
|||
| This plugin adds completions and aliases for [Gradle](https://gradle.org/). | |||
There was a problem hiding this comment.
This plugin doesn't seem to provide completions. Is there a plan to add them?
| done | ||
|
|
||
| # if gradlew found, run it instead of gradle | ||
| if [[ -f "$project_root/gradlew" ]]; then |
There was a problem hiding this comment.
| if [[ -f "$project_root/gradlew" ]]; then | |
| if [[ -x "$project_root/gradlew" ]]; then |
|
|
||
| # if gradlew found, run it instead of gradle | ||
| if [[ -f "$project_root/gradlew" ]]; then | ||
| echo "executing gradlew instead of gradle" |
There was a problem hiding this comment.
In case the user pipes the commands, I think this type of informative message should go to stderr. What do you think?
| echo "executing gradlew instead of gradle" | |
| echo "executing gradlew instead of gradle" >&2 |
|
|
||
| function gradle-or-gradlew() { | ||
| # find project root | ||
| # taken from https://github.com/gradle/gradle-completion |
There was a problem hiding this comment.
That code seems to be licensed under the MIT license, meaning that the original copyright notice should be retained. Please include it.
I checked the upstream OMZ plugin and realized that this PR is actually not just similar but based on the OMZ plugin. In that case, could you also mention the upstream OMZ plugin in the code comment? Since the upstream is a moving target, it is better to keep the permalink that ours is based on: |
Added Gradle plugin similar to what we have in oh-my-zsh