Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added page for Supporters #5

Merged
merged 10 commits into from
Aug 11, 2024
Merged

Added page for Supporters #5

merged 10 commits into from
Aug 11, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Jul 28, 2024

fixes #4

Copy link

vercel bot commented Jul 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2024 8:24pm

@dauntlessnomad
Copy link
Member

dauntlessnomad commented Aug 7, 2024

📝 Changed routes:

/care /
Screenshot of /care
(view full size)
Screenshot of /
(view full size)
/supporters
Screenshot of /supporters
(view full size)

1 deleted route:

  • /api/hello

Commit 567601a (https://landing-bvnaucsr3-ohcnetwork.vercel.app).

@gigincg
Copy link
Member

gigincg commented Aug 8, 2024

@shivankacker Can you stash Products for now, fix the Header and add a Supporters Page. Let's expedite and ship these by tomorrow, and work on Products pages separately

@shivankacker shivankacker marked this pull request as ready for review August 10, 2024 07:13
@shivankacker shivankacker changed the title Added page for CARE Added page for Supporters Aug 10, 2024
@nihal467
Copy link
Member

nihal467 commented Aug 10, 2024

@shivankacker

  • we are missing few supporters, such as cypress , browserstack, gcloud, azure, @shivankacker can you re-verify the list

image

  • When you hover over the supporters' icons, the cursor indicates that they are clickable, but clicking on them does not redirect you to any page. So either give redirection to respective website or make the icon non-clickable @gigincg what do you think

image

  • the footer is missing for this supporters page, was that intentional kept like that ?

image

  • Icons such as OpenAI, GitHub, CircleCI, Sentry, and Vercel don't have a hover effect. If the icons are fully black, apply a grey shade like we have for the Cloudflare icon. Then, on hover, display the fully black version of the icon.
  • For example, some icons like Slack have the text in full black while the corresponding icon has a greyed-out effect. To keep it consistent across the page, apply the same grey shade to both the icon and the text. On hover, display them in full color.

image

  • Update the title tag of the page appropriately. Currently, when we're on the supporters' page, the title of the page does not change.

cc; @gigincg

@shivankacker
Copy link
Member Author

@nihal467

1 : I put everything Bodhi and Syam asked, is there a list with all the requested supporters?
2, 4, 5 : I turned the grayscale effect off all together, and removed the pointer cursor
3: Added footer
6: Added page title

@gigincg gigincg merged commit e7e5a92 into main Aug 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Features Page for CARE
4 participants