-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solved #20 i.e contact link is now working from other than homepage #21
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for landing-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Wait it was working fine on my localhost but I checked it just now in deployed preview link. It is not working. Can you look into it? I mean I am not getting it why it happended. |
@thecodephilic-guy probably because |
@thecodephilic-guy is this PR complete? Doesn't seem to work for me. |
components/Footer.tsx
Outdated
const observer = new MutationObserver(() => { | ||
handleScrollToHash(); | ||
observer.disconnect(); // Disconnect after one scroll to prevent repeated triggers | ||
}); | ||
|
||
observer.observe(document.body, { attributes: true, subtree: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a bit overkill for a small issue. Let's stick to just taking the user to /#contact without the scroll behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah actually it is and I have rolled my to previous one. But I am still struggling with the problem that it is not taking to the /#contact when user is on supporters page or may be care page. I tried faking the network speed during development it worked there but only for localhost. I need some more time to go to the core of the problem. I have the intuation it is just a minor one but I am not able to get it.
It still did not work. Right now the code is in it's simplest form for this footer compoent. |
@thecodephilic-guy maybe instead of routing through the router.push method just use a |
Fixed #20