"fixes UI bugs with symptoms editor" #8998 #9003

Srayash · 2024-11-05T15:00:47Z

Proposed Changes

Fixes Fix UI bugs with Symptoms editor and move to ModelCrudEditor component #8998
Align the dropdown Icon in the search for symptoms input field.
Add padding and change placeholder text to avoid overlap.

Before

After

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced visual spacing for the DateInputV2 component.
- Improved dropdown button rendering and loading state handling in the AutocompleteMultiselect component.
- Updated placeholder text in the AddSymptom component for clarity.
Bug Fixes
- Refined selection logic for the "select-all" option in the AutocompleteMultiselect component.

coderabbitai · 2024-11-05T15:00:57Z

Walkthrough

The pull request includes modifications to three components: DateInputV2, AutocompleteMultiSelect, and SymptomsBuilder. Changes to DateInputV2 involve updating the input element's class name for improved visual spacing. The AutocompleteMultiSelect component sees updates to dropdown button rendering, loading state handling, and selection logic. Lastly, the SymptomsBuilder component features a minor text change in the placeholder and an update to the symptom addition logic. Overall, these changes focus on enhancing UI elements without altering core functionalities.

Changes

File Path	Change Summary
`src/components/Common/DateInputV2.tsx`	Updated class name of input element in `PopoverButton` to include `pr-5` for better spacing.
`src/components/Form/FormFields/AutocompleteMultiselect.tsx`	Modified dropdown button rendering, loading state handling, and refined `onChange` handler for selection logic. Updated types for clarity without signature changes.
`src/components/Symptoms/SymptomsBuilder.tsx	Changed placeholder text for `onset_date` field and updated `handleAdd` function for symptom addition.

Assessment against linked issues

Objective	Addressed	Explanation
Fix the overlap in date input	✅
Fix the dropdown icon	✅
Port over the `<EncounterSymptomsBuilder>` component	❌	No changes related to porting the component were made.

Possibly related PRs

Fix same-day discharge date selection in DateInputV2 component #9014: This PR modifies the DateInputV2 component, which is directly related to the main PR that also changes the DateInputV2 component, specifically enhancing the visual layout of the input field.

Suggested labels

needs review, needs testing, good to merge

Suggested reviewers

rithviknishad
shivankacker

🐰 In the garden, changes bloom bright,
A date input now feels just right.
Dropdowns dance with a new flair,
Symptoms added with utmost care.
Hopping along, we celebrate,
A UI fresh, oh, isn't it great? 🌼

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3e75fe4 and 45f361a.

📒 Files selected for processing (1)

src/components/Common/DateInputV2.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/Common/DateInputV2.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-11-05T15:01:04Z

❌ Deploy Preview for care-ohc failed.

Name	Link
🔨 Latest commit	`45f361a`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/672beee392a41400085879a7

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/components/Form/FormFields/AutocompleteMultiselect.tsx (1)
150-157: LGTM! Consider extracting icon size to a constant.

The changes properly address the dropdown icon alignment issue by using consistent text sizing and proper contrast. The implementation handles both loading and non-loading states appropriately.

Consider extracting the text-lg class to a constant since it's used in multiple places within the component:
+ const ICON_SIZE_CLASS = "text-lg";

  <div className="text-lg text-secondary-900">
    {props.isLoading ? (
-     <CareIcon icon="l-spinner" className="animate-spin" />
+     <CareIcon icon="l-spinner" className={classNames(ICON_SIZE_CLASS, "animate-spin")} />
    ) : (
      <CareIcon
        id="dropdown-toggle"
        icon="l-angle-down"
-       className="text-lg"
+       className={ICON_SIZE_CLASS}
      />
    )}
  </div>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6b57124 and 6f28f85.

📒 Files selected for processing (3)

src/components/Common/DateInputV2.tsx (1 hunks)
src/components/Form/FormFields/AutocompleteMultiselect.tsx (1 hunks)
src/components/Symptoms/SymptomsBuilder.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (2)

src/components/Common/DateInputV2.tsx
src/components/Symptoms/SymptomsBuilder.tsx

src/components/Symptoms/SymptomsBuilder.tsx

nihal467 · 2024-11-06T12:48:46Z

once the requested changes in the issues are made, request for review of the PR

Co-authored-by: Mohammed Nihal <[email protected]>

Srayash added 2 commits November 5, 2024 19:40

vertically align the dropdown icon.

6f74b0f

update placeholder text and add padding to avoid overlap

6f28f85

Srayash requested a review from a team as a code owner November 5, 2024 15:00

coderabbitai bot reviewed Nov 5, 2024

View reviewed changes

nihal467 reviewed Nov 6, 2024

View reviewed changes

src/components/Symptoms/SymptomsBuilder.tsx Outdated Show resolved Hide resolved

nihal467 added the changes required label Nov 6, 2024

Srayash and others added 2 commits November 7, 2024 00:26

change 'onset' to 'Onset'

3e75fe4

Co-authored-by: Mohammed Nihal <[email protected]>

Merge branch 'ohcnetwork:develop' into issues/ohcnetwork#8998/UI-fixes

45f361a

github-actions bot added the Deploy-Failed Deplyment is not showing preview label Nov 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"fixes UI bugs with symptoms editor" #8998 #9003

"fixes UI bugs with symptoms editor" #8998 #9003

Srayash commented Nov 5, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 5, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Nov 5, 2024 •

edited

Loading

coderabbitai bot left a comment

nihal467 commented Nov 6, 2024

"fixes UI bugs with symptoms editor" #8998 #9003

Are you sure you want to change the base?

"fixes UI bugs with symptoms editor" #8998 #9003

Conversation

Srayash commented Nov 5, 2024 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Nov 5, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Nov 5, 2024 • edited Loading

❌ Deploy Preview for care-ohc failed.

coderabbitai bot left a comment

Choose a reason for hiding this comment

nihal467 commented Nov 6, 2024

Srayash commented Nov 5, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 5, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Nov 5, 2024 •

edited

Loading