fix: Update tooltip position and rotation in Discussion Notes panel #8938

shauryag2002 · 2024-10-27T12:57:54Z

Proposed Changes

Fixes "Minimize" and "Close" Tooltip Issues in Discussion Notes #8937
Corrected the conditional class name for tooltip rotation.
Ensured consistent tooltip positioning based on the show state.

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced visual feedback for minimizing and closing patient notes with updated icons and tooltips.
Bug Fixes
- Improved tooltip text to accurately reflect the current state of the notes section.
Refactor
- Adjusted rendering logic and state management for better user interface experience.

…mponent

netlify · 2024-10-27T12:58:12Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`af5a4f8`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/672244369c7e030008adb5e5
😎 Deploy Preview	https://deploy-preview-8938--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shivankacker

I think rather than updating the tooltip class for minimize, you should update the parent element to not be rotated. The rotation should only be added to the CareIcon if at all needed, or you can just change the icon to l-angle-down conditionally.

…mponent

khavinshankar · 2024-10-30T14:15:18Z

src/components/Facility/PatientNotesSlideover.tsx

+        <span
+          className={`tooltip-text tooltip-${show ? "bottom -translate-x-16" : "top"} text-xs`}
+        >


use cn or classNames utils to add conditional classes, string interpolation can be hard to read sometimes

@khavinshankar ,Done.

khavinshankar · 2024-10-30T14:15:28Z

src/components/Facility/PatientNotesSlideover.tsx

+        <span
+          className={`tooltip-text tooltip-${show ? "bottom -translate-x-11" : "top"} text-xs`}
+        >


@khavinshankar ,Done.

…er component

…auryag2002/care_fe into issues/8937/fix-notes-tooltip

nihal467 · 2024-11-04T21:07:33Z

LGTM

bodhish · 2024-11-05T10:51:06Z

@coderabbitai full review

coderabbitai · 2024-11-05T10:51:12Z

✅ Actions performed

Full review triggered.

coderabbitai · 2024-11-05T10:51:15Z

Walkthrough

The changes in PatientNotesSlideover.tsx involve updates to the rendering logic and state management for displaying patient notes. The show state variable is now utilized to conditionally render icons and tooltips for minimizing and closing the notes section. Icon toggling and tooltip text adjustments enhance user interaction. The core functionality, including error handling and notification management, remains unchanged, while minor class name adjustments improve tooltip visibility based on the notes section's state.

Changes

Files	Change Summary
src/components/Facility/PatientNotesSlideover.tsx	Modified rendering logic for tooltips and icons based on `show` state; adjusted tooltip text and class names; retained core functionality and error handling.

Assessment against linked issues

Objective	Addressed	Explanation
The "Minimize" tooltip should display horizontally and align correctly above or below the button. (8937)	✅
The "Close" tooltip should remain fully visible within the screen boundaries. (8937)	✅

Possibly related PRs

displaying full names on hover for long names only #8972: The changes in this PR also focus on enhancing the user interface through tooltip features, similar to the modifications made in PatientNotesSlideover.tsx for displaying dynamic tooltip text based on state.

Poem

🐇 In the notes where patients dwell,
Tooltips now align and tell,
With icons bright, they rise and fall,
A better view for one and all!
So hop along, let’s celebrate,
A UI change that feels just great! 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between a0e6e62 and af5a4f8.

📒 Files selected for processing (1)

src/components/Facility/PatientNotesSlideover.tsx (2 hunks)

🔇 Additional comments (3)

src/components/Facility/PatientNotesSlideover.tsx (3)

160-162: LGTM! Icon state correctly reflects panel state.

The icon toggle between "l-angle-down" and "l-angle-up" based on the show state provides clear visual feedback about the panel's state.

163-169: LGTM! Tooltip positioning is now correctly handled.

The tooltip positioning has been improved by:

Using classNames utility for better class management
Conditionally applying position and translation based on panel state
Ensuring tooltip remains visible in both expanded and minimized states

180-187: LGTM! Close tooltip visibility is fixed.

The close tooltip implementation follows the same pattern as the minimize tooltip, ensuring consistent behavior and visibility in both expanded and minimized states.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

fix: Update tooltip position and rotation in PatientNotesSlideover co…

f748f55

…mponent

shauryag2002 requested a review from a team as a code owner October 27, 2024 12:57

shivankacker requested changes Oct 27, 2024

View reviewed changes

shivankacker added the changes required label Oct 27, 2024

fix: Update tooltip position and rotation in PatientNotesSlideover co…

fb06e6c

…mponent

shauryag2002 requested a review from shivankacker October 30, 2024 14:11

khavinshankar requested changes Oct 30, 2024

View reviewed changes

shauryag2002 added 3 commits October 30, 2024 20:03

refactor: Update tooltip position and rotation in PatientNotesSlideov…

39bef8a

…er component

Merge branch 'develop' into issues/8937/fix-notes-tooltip

269a069

Merge branch 'issues/8937/fix-notes-tooltip' of https://github.com/sh…

af5a4f8

…auryag2002/care_fe into issues/8937/fix-notes-tooltip

shauryag2002 requested a review from khavinshankar October 30, 2024 14:36

shivankacker approved these changes Nov 4, 2024

View reviewed changes

shivankacker added needs testing and removed changes required labels Nov 4, 2024

nihal467 added needs review tested and removed needs testing labels Nov 4, 2024

rithviknishad approved these changes Nov 6, 2024

View reviewed changes

rithviknishad added needs review and removed needs review labels Nov 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Update tooltip position and rotation in Discussion Notes panel #8938

fix: Update tooltip position and rotation in Discussion Notes panel #8938

shauryag2002 commented Oct 27, 2024 •

edited by coderabbitai bot

Loading

netlify bot commented Oct 27, 2024 •

edited

Loading

shivankacker left a comment

khavinshankar Oct 30, 2024

shauryag2002 Oct 30, 2024

khavinshankar Oct 30, 2024

shauryag2002 Oct 30, 2024

nihal467 commented Nov 4, 2024

bodhish commented Nov 5, 2024

coderabbitai bot commented Nov 5, 2024

coderabbitai bot commented Nov 5, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

fix: Update tooltip position and rotation in Discussion Notes panel #8938

Are you sure you want to change the base?

fix: Update tooltip position and rotation in Discussion Notes panel #8938

Conversation

shauryag2002 commented Oct 27, 2024 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

netlify bot commented Oct 27, 2024 • edited Loading

✅ Deploy Preview for care-ohc ready!

shivankacker left a comment

Choose a reason for hiding this comment

khavinshankar Oct 30, 2024

Choose a reason for hiding this comment

shauryag2002 Oct 30, 2024

Choose a reason for hiding this comment

khavinshankar Oct 30, 2024

Choose a reason for hiding this comment

shauryag2002 Oct 30, 2024

Choose a reason for hiding this comment

nihal467 commented Nov 4, 2024

bodhish commented Nov 5, 2024

coderabbitai bot commented Nov 5, 2024

coderabbitai bot commented Nov 5, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

shauryag2002 commented Oct 27, 2024 •

edited by coderabbitai bot

Loading

netlify bot commented Oct 27, 2024 •

edited

Loading

coderabbitai bot commented Nov 5, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)