Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes security issue with Avatar Edit Modal #8917

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 24, 2024

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Ensure that UI text is kept in I18n files.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner October 24, 2024 10:50
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 443e42f
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/671a29f409a1ad0008a00bd1
😎 Deploy Preview https://deploy-preview-8917--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad added needs testing needs review urgent P1 breaking issue or vital feature labels Oct 24, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 24, 2024

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 443e42f
Status: ✅  Deploy successful!
Preview URL: https://156762fb.care-fe.pages.dev
Branch Preview URL: https://rithviknishad-fix-security-i.care-fe.pages.dev

View logs

Copy link

cypress bot commented Oct 24, 2024

CARE    Run #3739

Run Properties:  status check passed Passed #3739  •  git commit 443e42fcfa: Fixes security issue with Avatar Edit Modal
Project CARE
Branch Review rithviknishad/fix/security-issue-avatar-edit
Run status status check passed Passed #3739
Run duration 03m 10s
Commit git commit 443e42fcfa: Fixes security issue with Avatar Edit Modal
Committer Rithvik Nishad
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 merged commit c62b36d into develop Oct 24, 2024
27 checks passed
@nihal467 nihal467 deleted the rithviknishad/fix/security-issue-avatar-edit branch October 24, 2024 15:26
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Concern reported by GitHub bot in the Avatar Edit Modal
4 participants