Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow Users to Edit and Delete Their Own Comments in shifting a… #8724

Closed
wants to merge 1 commit into from

Conversation

anshux1
Copy link

@anshux1 anshux1 commented Oct 5, 2024

Proposed Changes

Screencast.from.2024-10-06.01-16-46.webm

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@anshux1 anshux1 requested a review from a team as a code owner October 5, 2024 19:52
Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit c8aebd5
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6701991cf7187300083d50be
😎 Deploy Preview https://deploy-preview-8724--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bodhish
Copy link
Member

bodhish commented Oct 7, 2024

@anshux1 does out backend even support this 🤔

In healthcare, we just don't allow users to delete data from the system. They can always add another a comment explaning the error.

@bodhish bodhish added the blocked label Oct 7, 2024
@anshux1
Copy link
Author

anshux1 commented Oct 9, 2024

@bodhish I understand the sensitivity of data in healthcare systems.

Given this context, I propose the following approach:

  1. For the edit functionality:

    • I'll open an issue in the backend repo to add a route for updating comments.
    • Once that's implemented, we can add the edit feature to the frontend.
  2. For the delete functionality:

    • Instead of deleting comments, we could implement a "soft delete" where comments are marked as retracted but still visible in the system.

This approach maintains data integrity while still giving users some control over their comments.
Should i proceed with implementing the edit functionality and a modified version of the delete functionality?

@bodhish
Copy link
Member

bodhish commented Oct 21, 2024

Users have not complained that they want edit or delete so why would be build it 🤔

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 22, 2024
Copy link

👋 Hi, @anshux1,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@anshux1 anshux1 closed this Oct 26, 2024
@anshux1 anshux1 deleted the feat/comment-edit-delete branch October 26, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked merge conflict pull requests with merge conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Allow Users to Edit and Delete Their Own Comments in shifting and Resource
2 participants