Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phys2bids project #209

Merged
merged 3 commits into from
Jun 14, 2020
Merged

Add phys2bids project #209

merged 3 commits into from
Jun 14, 2020

Conversation

smoia
Copy link

@smoia smoia commented Jun 14, 2020

I'd like to add the project snippet for #193 .
Since the project is in two hubs, how should that field be formatted?

@welcome
Copy link

welcome bot commented Jun 14, 2020

Thank You Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808)
💖 Thanks for opening this pull request! 💖 We really appreciate your time and effort to contribute to the project. If you are trying to add your contribution to our Venue page, please make sure you have read our instructions and have shared all relevant details in your pull request. The OHBM Brainhack webteam might be a bit busy right now but we will have a look at your suggestion very quickly.

@jhlegarreta
Copy link
Collaborator

@smoia looks like the project was already added to the website:
https://github.com/ohbm/hackathon2020/blob/master/_data/projects.yml#L307

in commit 5dd9e70 👍

See:
https://ohbm.github.io/hackathon2020/hackathon/

Check if how the hub is presented seems OK to you ❓ . If it is OK, and if this sounds OK to you ❓ , then we will need to close this PR without being merged.

@smoia
Copy link
Author

smoia commented Jun 14, 2020

I'm sorry - I didn't see it!

Would it be possible to change the description in the website, like this:

details: "<a href="https://github.com/physiopy/phys2bids">Physiopy</a> is a github organisation that aims to offer open development solutions for physiology in MRI.
  <a href="https://github.com/physiopy/phys2bids">phys2bids</a> is the flagship library of physiopy, and it consists in a python3 library meant to format physiological
  (cardiac, respiratory, or gas signals) files in BIDS. <br>During this hackathon, we would love to involve new contributors to integrate new features, such as
  automatic recognition of the file content, support for eyetracking, and integration with other bidsificators (such as <a href="https://bidscoin.readthedocs.io">bidscoin</a>) 
  Next to phys2bids, we’re starting the development of phys2denoise, a library dedicated to prepare physiological signal for fMRI denoising.
  <br>More information <a href=https://github.com/ohbm/hackathon2020/issues/193>in this github issue</a>"

I modified it in this PR, but if it's not too much trouble to change it and it's more practical to change it someway else, better!

@jhlegarreta
Copy link
Collaborator

jhlegarreta commented Jun 14, 2020

@smoia it's fine to modify it 👍. However, the quotes in the hyper-links seem not to be supported by the system, e.g.
<a href="https://github.com/physiopy/phys2bids">Physiopy</a> to
<a href=https://github.com/physiopy/phys2bids>Physiopy</a>

and so on. Will you change them, please? Thanks !

@jhlegarreta
Copy link
Collaborator

@smoia thanks 🎉 ! Tests are passing. Merging.

@jhlegarreta jhlegarreta merged commit 0b6c695 into ohbm:master Jun 14, 2020
@welcome
Copy link

welcome bot commented Jun 14, 2020

Congratulations Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. http://doi.org/10.5281/zenodo.3332808)
Congrats on merging your first pull request! 🎉 We here at OHBM Brainhack team really appreciate your contribution! 💖 Go ahead and share your your first merge with your colleagues, you got yourself this brag right! 😄 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants