chore: update GLTF Loader types #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @pschroen. Do you think it would be possible, anytime soon, to add the GLTF sparse accessor functionality for shape key/morphing animations? Thanks |
|
@monolithMktg this PR is for the type definitions only. |
|
@pschroen Yes, I am aware. Since, it relates to GLTF, just wanted to ask you if it's possible to get the "morphing geometry" ability added in OGL in near future. :) |
|
@monolithMktg if you're talking about #228 that's an open feature request and if someone has time to contribute that they will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirroring the camera updates from a few months ago, plus re-tested to make sure the existing type definitions still work.