Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use legacy syntax for decorators #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anehx
Copy link
Contributor

@anehx anehx commented Nov 26, 2019

This commit rewrites the decorators withParachute and queryParam to
use the stage 1 legacy decorator syntax since ember uses that syntax for
now. For more infos see https://github.com/ember-decorators/ember-decorators/blob/master/README.md#specs.

This will fix the usage of ember-parachutes decorators with newer versions of ember / ember-decorators.

Jonas Metzener added 2 commits November 26, 2019 13:33
This commit rewrites the decorators `withParachute` and `queryParam` to
use the stage 1 legacy decorator syntax since ember uses that syntax for
now. For more infos see https://github.com/ember-decorators/ember-decorators/blob/master/README.md#specs.
@anehx
Copy link
Contributor Author

anehx commented Nov 26, 2019

This also drops support for node 6 since it's EOL is 2019-04-30 and ember-decorators v6+ doesn't support it

@anehx
Copy link
Contributor Author

anehx commented Nov 27, 2019

@offirgolan I don't really see the reason for the failing tests.. Maybe cleaning the Travis CI cache would help?

@anehx
Copy link
Contributor Author

anehx commented Dec 9, 2019

Sadly I just learned that this doesn't really work the way I intended it.. The routes setup hook which initializes the QPs values uses a computed property _qp which uses the owner.lookup method to get the controller definition. If the controllers queryParams property is defined via Controller.reopen it does not exist then (not quite sure why, since controllers are supposed to be a singleton).

Long story short, this won't work properly. I don't have any more ideas how to solve it. If someone has an idea I'm very willing to try it out..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant