[WIP] Attempt to optimize the position skipping to fit a distribution. #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old algorithm work online and therefore might discard excessive amounts of positions. The new algorithm filters the buffers that are filled in each worker thread (currently each buffer is around 1M elements). This offline algorithm allows more exact distribution match and less wasted positions. It is however tied to the implementation of the buffering, which is not done for .bin files (so it currently is not implemented for .bin files), and the buffer size will now have (a small) effect. Similarly FEN stream filtering no longer uses this type of skipping.
|
Appears to be bugged currently in some way. Testing shows networks degrade during training which is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old algorithm work online and therefore might discard excessive amounts of positions.
The new algorithm filters the buffers that are filled in each worker thread
(currently each buffer is around 1M elements). This offline algorithm allows more exact
distribution match and less wasted positions. It is however tied to the implementation of the buffering,
which is not done for .bin files (so it currently is not implemented for .bin files), and the buffer size will
now have (a small) effect. Similarly FEN stream filtering no longer uses this type of skipping.