Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and Update KAM Support for KAM 2.13.3 #3087

Conversation

Apricot-ale
Copy link

@Apricot-ale Apricot-ale commented Dec 7, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
This PR is to fix issue submitted to KAT Advanced Medical (KAM). KAT-Advanced-Medical/KAM#423
And this PR will apply item compatibility updates to Antistasi that correspond to the latest version of KAM (2.13.3).

Please specify which Issue this PR Resolves.

This issue has been reported to KAM, see KAT-Advanced-Medical/KAM#423

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:
N/A


Notes:
N/A

@Apricot-ale Apricot-ale changed the title Update fn_aceModCompat.sqf Add KAM Support 2.13.3 Dec 7, 2023
@Bob-Murphy Bob-Murphy added this to the 3.5 milestone Dec 7, 2023
@Bob-Murphy Bob-Murphy self-assigned this Dec 7, 2023
@Bob-Murphy Bob-Murphy self-requested a review December 7, 2023 11:17
@Apricot-ale Apricot-ale changed the title Add KAM Support 2.13.3 Add and Update KAM Support for KAM 2.13.3 Dec 7, 2023
banana, sunflower seed, humanitarian ration is not related this PR...
@Bob-Murphy
Copy link

The last released version of KAM is 2.13.2 and this PR is for 2.13.3rc2.
Please note that we only merge for released versions, not for RC builds, as this could lead to issues for players because of incompatibility.
Either revert this to 2.13.2 or let me know when 2.13.3 actually is released.
Thank you.

@Bob-Murphy Bob-Murphy added Not now Please don't work on this until this tag is removed. Work needed and removed Review pending labels Dec 7, 2023
@Apricot-ale
Copy link
Author

The last released version of KAM is 2.13.2 and this PR is for 2.13.3rc2. Please note that we only merge for released versions, not for RC builds, as this could lead to issues for players because of incompatibility. Either revert this to 2.13.2 or let me know when 2.13.3 actually is released. Thank you.

Understood.
The KAM stable release of 2.13.4 should be coming soon follows DEV 2.13.3rc2, so when it comes, I tell you.

@Apricot-ale
Copy link
Author

The last released version of KAM is 2.13.2 and this PR is for 2.13.3rc2. Please note that we only merge for released versions, not for RC builds, as this could lead to issues for players because of incompatibility. Either revert this to 2.13.2 or let me know when 2.13.3 actually is released. Thank you.

KAM stable version 2.13.3 has been released, with no major changes compared to DEV2.13.3.rc2.
It is safe to merge it in this state.

@Apricot-ale
Copy link
Author

If (unscheduled) 3.4.2 is ever released, it is recommended that this PR be included there.
If 3.5 is still a long way off, new items may be added to the KAM in a new update before then.

@Bob-Murphy Bob-Murphy added Enhancement New feature or request Ready for merge and removed Not now Please don't work on this until this tag is removed. Work needed labels Dec 23, 2023
@Bob-Murphy Bob-Murphy merged commit ece595f into official-antistasi-community:unstable Dec 23, 2023
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Enhancement New feature or request Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants