This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
fix disable browser autocomplete - Closes #422 #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Chrome doesn't take into account any more the autocomplete="off" attribute. As a result, the browser's autocomplete suggestions will overlap the suggestions we actually want to display with this component. - The only available workaround for now seems to be to give a value which is semantically significant for the given input, but which can't be interpreted by the browser as a known value for autocomplete.
nyvio
changed the title
nyvio
changed the title
There was a problem hiding this comment.
This approach seems to work 100% and fixes the issue 👍 :) thanks @nyvio
NewteqDeveloper
approved these changes
Mar 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome doesn't take into account any more the html autocomplete="off" attribute.
As a result, the browser's autocomplete suggestions will overlap the suggestions we actually want to display with this component.
The only available workaround for now seems to be to give a value which is semantically significant for the given input, but which can't be interpreted by the browser as a known value for autocomplete.
See here, the reply from Chromium on this specific issue: https://bugs.chromium.org/p/chromium/issues/detail?id=468153#c164
It is a quick and effective workaround, which has a real impact for us.
Feel free to comment, I'm open to discussion and happy to contribute.