Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oemof-visio changes labels of nodes to strings #9

Open
tscherwath opened this issue Jan 28, 2022 · 3 comments
Open

oemof-visio changes labels of nodes to strings #9

tscherwath opened this issue Jan 28, 2022 · 3 comments

Comments

@tscherwath
Copy link

Not sure if this a bug, if not please just close.

Calling class ESGGrapgRenderer is overwriting the labels of the energysystem.nodes with strings:

image

Starting in line 164:

        # draw a node for each of the energy_system's component.
        # the shape depends on the component's type.
        for nd in energy_system.nodes:
            # make sur the label is a string and not a tuple
            nd.label = str(nd.label)

best
Tim

@joe29k
Copy link

joe29k commented May 11, 2024

This still seems to be an issue as I am constantly getting errors when using the graph plotting function of oemof-visio:
AttributeError: property 'label' of 'Bus' object has no setter.

Just removing this "conversion" line in the code leads to at least running without errors; however, there seem to be more issues with this package.

@p-snft
Copy link
Member

p-snft commented May 16, 2024

Honestly, oemof.visio is stale at the moment. In particular, for graph rendering, I'd suggest to use the function create_nx_graph from oemof.network.

@joe29k
Copy link

joe29k commented May 20, 2024

okay, thanks for the tip and clarification. Maybe then, some hint on the readme might be helpful for other potential users of this outdated repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants