Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESGraphRenderer seems not to work with newest oemof.solph components #11

Open
joe29k opened this issue May 11, 2024 · 2 comments
Open

Comments

@joe29k
Copy link

joe29k commented May 11, 2024

There is a problem when I try to plot my energy system consisting of oemof solph components (I use only newer components like Converter instead of Transformer to get rid of DeprecationWarnings.

After manually "fixing" some minor issue with labels (please also see issue #9),the problem is that the connections between Buses and Components are not drawn, moreover it seems not to correctly get the types of some components (like Sources, Sinks, ..). See the attached photo (excerpt):

Bildschirmfoto 2024-05-11 um 17 36 25

@joe29k
Copy link
Author

joe29k commented May 11, 2024

my suggested fix would involve changing the imports from

from oemof.network.network import Bus, Sink, Source, Transformer

to

 from oemof.solph.buses import Bus
 from oemof.solph.components import Sink, Source, Converter, GenericStorage

(as well as also changing Transformer in the then following code to Converter as well)

However, I am not completely sure if this then would also still work if oemof.network components are used, so there should be some checks; also the Error Handling should be adjusted accordingly.

Would be happy to see some update / fixes of the package addressing these issues

@joe29k
Copy link
Author

joe29k commented May 11, 2024

I also did some fork and did some updates so that it is working for me (https://github.com/joe29k/oemof-visio) but use it only at your own risk and be aware of the mentioned limitations (I might delete it sometime)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant