Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import of Facade class from oemof tabular's facades module #142

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MaGering
Copy link
Contributor

This PR

  • replaces the copy of the oemof.tabular.facades module in oemof.thermal's facades.py with an import of the required class (Facade) and
  • deletes obsolete imports

Related: Issue #127

@MaGering MaGering added this to the v0.0.3 milestone Jun 23, 2020
@MaGering MaGering requested a review from c-moeller June 23, 2020 10:52
@MaGering MaGering self-assigned this Jun 23, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2020

This pull request fixes 1 alert when merging 86a0f3d into 70b6c5f - view on LGTM.com

fixed alerts:

  • 1 for __eq__ not overridden when adding attributes

@c-moeller
Copy link
Member

Due to incompatibilities of package requirements when installing oemof-tabular together with oemof-solph v0.4.1, I would like to shift this to v0.0.4 If someone gets this running until tomorrow noon, feel free, otherwise let's shift this.

@c-moeller c-moeller modified the milestones: v0.0.3, v0.0.4 Jul 1, 2020
@c-moeller c-moeller removed this from the v0.0.4 milestone Sep 16, 2020
@c-moeller c-moeller removed their request for review September 30, 2020 13:11
@p-snft p-snft marked this pull request as draft February 13, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants