-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import oemof.tabular's base class Facade #127
Comments
I would suggest to shift this to v0.0.4 due to the workload in v0.0.3 and current activity in oemof-tabular. Is this ok for you? |
It could be done within a couple of minutes. This is not a lot of work in terms of programming. It may generate some work in the future, if changes have to be coordinated with oemof.tabular. And it will also keep things easier when someone wants to use the two packages together. It is a decision. if we need some more time for that, there is no need to hurry. |
Ok, I set it back to v0.0.3 |
Currently, importing from oemof.tabular would induce a version conflict:
Therefore, we should not import from oemof.tabular. Once oemof.tabular is updated, we could decide to import from there. I removed the milestone. Shall I leave this issue open as a reminder for later? |
I would leave it open. |
Currently, the facades in oemof.thermal inherit from a base class that has been copied from oemof.tabular. This was done in the beginning to try the concept of facades and reduce the number of imports. Now, as both packages, oemof.tabular and oemof.tabular, get used more and more, we can as well import oemof.tabular. This would help to avoid divergent developments, keep compatibilty and would be in line with the new unbundled repo structure.
The text was updated successfully, but these errors were encountered: