Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import oemof.tabular's base class Facade #127

Open
jnnr opened this issue Jun 15, 2020 · 5 comments
Open

Import oemof.tabular's base class Facade #127

jnnr opened this issue Jun 15, 2020 · 5 comments

Comments

@jnnr
Copy link
Member

jnnr commented Jun 15, 2020

Currently, the facades in oemof.thermal inherit from a base class that has been copied from oemof.tabular. This was done in the beginning to try the concept of facades and reduce the number of imports. Now, as both packages, oemof.tabular and oemof.tabular, get used more and more, we can as well import oemof.tabular. This would help to avoid divergent developments, keep compatibilty and would be in line with the new unbundled repo structure.

@jnnr jnnr changed the title Import oemof.tabular's facades Import oemof.tabular's base class Facade Jun 15, 2020
@jnnr jnnr added this to the v0.0.3 milestone Jun 15, 2020
@jnnr jnnr self-assigned this Jun 15, 2020
@c-moeller
Copy link
Member

I would suggest to shift this to v0.0.4 due to the workload in v0.0.3 and current activity in oemof-tabular. Is this ok for you?

@c-moeller c-moeller modified the milestones: v0.0.3, v0.0.4 Jun 16, 2020
@jnnr
Copy link
Member Author

jnnr commented Jun 16, 2020

It could be done within a couple of minutes. This is not a lot of work in terms of programming. It may generate some work in the future, if changes have to be coordinated with oemof.tabular. And it will also keep things easier when someone wants to use the two packages together.

It is a decision. if we need some more time for that, there is no need to hurry.

@c-moeller c-moeller modified the milestones: v0.0.4, v0.0.3 Jun 17, 2020
@c-moeller
Copy link
Member

Ok, I set it back to v0.0.3

@jnnr
Copy link
Member Author

jnnr commented Sep 10, 2020

Currently, importing from oemof.tabular would induce a version conflict:

  • oemof.thermal relies on oemof.solph v0.4.0 or higher,
  • oemof.tabular is still not updated to oemof.solph v0.4.0.

Therefore, we should not import from oemof.tabular. Once oemof.tabular is updated, we could decide to import from there. I removed the milestone. Shall I leave this issue open as a reminder for later?

@jnnr jnnr removed this from the v0.0.4 milestone Sep 10, 2020
@c-moeller
Copy link
Member

I would leave it open.

@jnnr jnnr unassigned jnnr and MaGering Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants