Skip to content
This repository has been archived by the owner on Jan 27, 2019. It is now read-only.

Add musl #176

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add musl #176

wants to merge 5 commits into from

Conversation

sknsean
Copy link
Contributor

@sknsean sknsean commented Oct 18, 2016

No description provided.

@@ -229,6 +229,7 @@ do_configure_gcc() {
--disable-multilib \
--disable-multiarch \
--with-system-zlib \
--disable-libsanitizer \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you plan to get around this? You have marked the commit disabling libsanitizer with "THIS IS ONLY FOR TESTING WITH MUSL"...

@@ -0,0 +1,61 @@
inherit autotools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the standard boiler plate information, such as DESCRIPTION, LICENSE, HOMEPAGE.


SRC_URI = "https://www.musl-libc.org/releases/musl-${PV}.tar.gz"

#EXTRA_OECONF += "--enable-shared"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this commented out line?

#EXTRA_OECONF += "--enable-shared"
RECIPE_TYPES = "machine sdk"

MACHINE[unexport] = "1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you doing this? I cannot seem to find any references to MACHINE environment variable in musl. I suspect this is a copy-paste legacy from glibc recipe. Please fix.


do_install[postfuncs] += "do_install_extra_files"
do_install_extra_files() {
# ln -s ../../${libdir}/libc.so ${D}${bindir}/ldd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this commented out line?

AUTO_PACKAGE_LIBS_LIBDIR += "${sharedlibdir}:lib:::.so"
AUTO_PACKAGE_LIBS_LIBDIR += "${libdir}:lib:::.a,_nonshared.a,_pic.a,_pic.map"
#AUTO_PACKAGE_LIBS:>HOST_CPU_powerpc = " nldbl"
#AUTO_PACKAGE_LIBS_DEV_FILES .= ",_nonshared.a,_pic.a,_pic.map"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More commented out lines...

AUTO_PACKAGE_LIBS_DEV_DEPENDS = "${PN}-dev"
AUTO_PACKAGE_LIBS_DEV_RDEPENDS = "${PN}-dev"
AUTO_PACKAGE_LIBS_DEPENDS = "ld-so libc"
AUTO_PACKAGE_LIBS_RDEPENDS = "ld-so libc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you are also auto-packaging libc, you end up with a dependency on itself for that. I guess it has turned out to not cause problems (for now), but I don't think it is something it is worth relying on. It might be better to add libc as explicit dependency for all those libraries needing it (even if it is all but libc itself).

@ghost
Copy link

ghost commented Feb 9, 2017

depends on #221

@ghost
Copy link

ghost commented Feb 9, 2017

and #181

Signed-off-by: Sean Nyekjaer <[email protected]>
Signed-off-by: Sean Nyekjaer <[email protected]>
Signed-off-by: Sean Nyekjaer <[email protected]>
Signed-off-by: Sean Nyekjaer <[email protected]>
Signed-off-by: Sean Nyekjaer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants