-
Notifications
You must be signed in to change notification settings - Fork 17
Add musl #176
base: master
Are you sure you want to change the base?
Add musl #176
Conversation
recipes/gcc/gcc-common.inc
Outdated
@@ -229,6 +229,7 @@ do_configure_gcc() { | |||
--disable-multilib \ | |||
--disable-multiarch \ | |||
--with-system-zlib \ | |||
--disable-libsanitizer \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you plan to get around this? You have marked the commit disabling libsanitizer with "THIS IS ONLY FOR TESTING WITH MUSL"...
recipes/musl/musl_1.1.15.oe
Outdated
@@ -0,0 +1,61 @@ | |||
inherit autotools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the standard boiler plate information, such as DESCRIPTION, LICENSE, HOMEPAGE.
recipes/musl/musl_1.1.15.oe
Outdated
|
||
SRC_URI = "https://www.musl-libc.org/releases/musl-${PV}.tar.gz" | ||
|
||
#EXTRA_OECONF += "--enable-shared" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove this commented out line?
recipes/musl/musl_1.1.15.oe
Outdated
#EXTRA_OECONF += "--enable-shared" | ||
RECIPE_TYPES = "machine sdk" | ||
|
||
MACHINE[unexport] = "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you doing this? I cannot seem to find any references to MACHINE environment variable in musl. I suspect this is a copy-paste legacy from glibc recipe. Please fix.
recipes/musl/musl_1.1.15.oe
Outdated
|
||
do_install[postfuncs] += "do_install_extra_files" | ||
do_install_extra_files() { | ||
# ln -s ../../${libdir}/libc.so ${D}${bindir}/ldd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this commented out line?
recipes/musl/musl_1.1.15.oe
Outdated
AUTO_PACKAGE_LIBS_LIBDIR += "${sharedlibdir}:lib:::.so" | ||
AUTO_PACKAGE_LIBS_LIBDIR += "${libdir}:lib:::.a,_nonshared.a,_pic.a,_pic.map" | ||
#AUTO_PACKAGE_LIBS:>HOST_CPU_powerpc = " nldbl" | ||
#AUTO_PACKAGE_LIBS_DEV_FILES .= ",_nonshared.a,_pic.a,_pic.map" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More commented out lines...
recipes/musl/musl_1.1.15.oe
Outdated
AUTO_PACKAGE_LIBS_DEV_DEPENDS = "${PN}-dev" | ||
AUTO_PACKAGE_LIBS_DEV_RDEPENDS = "${PN}-dev" | ||
AUTO_PACKAGE_LIBS_DEPENDS = "ld-so libc" | ||
AUTO_PACKAGE_LIBS_RDEPENDS = "ld-so libc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you are also auto-packaging libc, you end up with a dependency on itself for that. I guess it has turned out to not cause problems (for now), but I don't think it is something it is worth relying on. It might be better to add libc as explicit dependency for all those libraries needing it (even if it is all but libc itself).
depends on #221 |
and #181 |
Signed-off-by: Sean Nyekjaer <[email protected]>
Signed-off-by: Sean Nyekjaer <[email protected]>
Signed-off-by: Sean Nyekjaer <[email protected]>
Signed-off-by: Sean Nyekjaer <[email protected]>
Signed-off-by: Sean Nyekjaer <[email protected]>
No description provided.