This repository has been archived by the owner on Jan 27, 2019. It is now read-only.
classes/binconfig: create binconfig package instead of doing binconfig-fixup #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages that create a ${PN}-config script used by dependent packages
during their configure step, inherits the binconfig class to both fixup
paths in the script and to make the script available to dependent
packages during their stage step.
Until now, this was done by the binconfig class, which adds a call to
binconfig_stage_fixup() during the dependent stage step. However,
binconfig_stage_fixup() symlinks into ./stage/cross/bin/, which is
not "allowed" in the stage fixup functions. (They should only touch
./stage.unpack/ and not ./stage ).
Also, the symlink-during-stage fixup approach might fail as
./stage/cross/bin is not guarenteed to be created when
binconfig_stage_fixup() is called.
Fix this mess by changing the class to create the symlink during
do_install(), and adding the symlink to cross-package created in the
class (${PN}-binconfig). Provide this package to dependent packages
by adding cross:${PN}-binconfig as a dependency to the primary package.