Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tolerate "H" for hard derivation in message signing #44

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jdlcdl
Copy link

@jdlcdl jdlcdl commented Sep 24, 2024

Description

Noticed tolerance for different "hardened" derivation paths including "'" and "h" but not "H", just in case a message signing request comes in a file like:

Hello World from Sparrow 2.0.0 signed on krux pr_453
m/84'/1h/1H/0/20
P2WPKH

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (system_optimizations@ef92026). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             system_optimizations      #44   +/-   ##
=======================================================
  Coverage                        ?   94.67%           
=======================================================
  Files                           ?       70           
  Lines                           ?     7575           
  Branches                        ?        0           
=======================================================
  Hits                            ?     7172           
  Misses                          ?      403           
  Partials                        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odudex odudex merged commit b15b0e9 into odudex:system_optimizations Sep 24, 2024
5 checks passed
@odudex
Copy link
Owner

odudex commented Sep 24, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants