My First Odoo Application #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please enter the commit message for your changes. Lines starting Changes to be committed:
jnc-odoo
reviewed
Oct 9, 2024
Comment on lines
+73
to
+77
| for property in self: | ||
| if property.state == "cancelled": | ||
| raise UserError(_("Cancelled properties cannot be sold!")) | ||
| property.state = "sold" | ||
|
|
There was a problem hiding this comment.
This was the solution of the slides. I suggest that you check the filtered function from Odoo to see how you could change this code with it :D
Comment on lines
+90
to
+93
| def _unlink_if_new_or_canceled(self): | ||
| for property in self: | ||
| if property.state not in ("new", "canceled"): | ||
| raise UserError(_("Only new or canceled property can be deleted!")) |
There was a problem hiding this comment.
The same here, you can check the filtered function :)
Comment on lines
+96
to
+98
| def create(self, vals_list): | ||
| for vals in vals_list: | ||
| property = self.env["estate.property"] |
| @@ -0,0 +1,41 @@ | |||
| from odoo import api, fields, models | |||
|
|
|||
| class Offer(models.Model): | |||
There was a problem hiding this comment.
Usually we uses the same name as the name of the model so here EstatePropertyOffer but it is more of a preference
|
|
||
| @api.depends("validity", "create_date") | ||
| def _compute_deadline(self): | ||
| for estate in self: |
There was a problem hiding this comment.
It would more appropriate to call your record with the model name
Suggested change
| for estate in self: | |
| for offer in self: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.