Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] test_themes: fix test for s_rating inner snippet in s_reviews_wall #991

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chgo-odoo
Copy link
Contributor

@chgo-odoo chgo-odoo commented Oct 17, 2024

This commit adds a line within the new_page_templates test in order to allow the snippet s_rating to be used with s_rating_no_title option activated. Since this inner snippet was never used within another one before, we didn't need to add such a line.

task-4264114
part of task-4077427

@robodoo
Copy link
Collaborator

robodoo commented Oct 17, 2024

Pull request status dashboard

@chgo-odoo chgo-odoo force-pushed the master-website-s_reviews_wall-chgo branch from 253e19a to 729c405 Compare October 17, 2024 11:10
@chgo-odoo chgo-odoo changed the title [IMP] test_themes: adapt test for s_rating_no_title [IMP] test_themes: fix test for s_rating inner snippet in s_reviews_wall Oct 17, 2024
@chgo-odoo chgo-odoo force-pushed the master-website-s_reviews_wall-chgo branch from 729c405 to 9bd3131 Compare October 25, 2024 11:06
@chgo-odoo chgo-odoo closed this Oct 28, 2024
@chgo-odoo chgo-odoo force-pushed the master-website-s_reviews_wall-chgo branch from 9bd3131 to 3adf9d6 Compare October 28, 2024 11:31
…s_wall`

This commit adds a line within the `new_page_templates` test in order to
allow the snippet `s_rating` to be used with `s_rating_no_title` option
activated. Since this inner snippet was never used within another one
before, we didn't need to add such a line.

task-4264114
part of task-4077427
@chgo-odoo chgo-odoo reopened this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants