Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] theme_bookstore: fix multiple issues in the theme #972

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[FIX] theme_bookstore: fix multiple issues in the theme #972

wants to merge 1 commit into from
+52 −69

Conversation

anso-odoo
Copy link

This commit fixes multiples issues in the theme:

  • Wording
  • Shapes that should appear only in the configurator
  • Useless xpaths

task-4221731

@robodoo
Copy link
Collaborator

robodoo commented Sep 30, 2024

Pull request status dashboard

@anso-odoo anso-odoo marked this pull request as ready for review September 30, 2024 16:29
@sobo-odoo sobo-odoo force-pushed the 18.0-theme_bookstore-post-merge-fixes-anso branch from 327b189 to df6362e Compare September 30, 2024 18:48
@sobo-odoo
Copy link
Contributor

sobo-odoo commented Sep 30, 2024 •
edited
Loading

@anso-odoo Thanks for the fixes 🙂
FYI I force-pushed to:

  • remove unused images from the manifest => tell me if I am wrong but the images_theme_preview images are only used to be called in the href right ? Since it was not the case for the banner one, I removed it, and I removed the duplicated image_text one 🙂
  • fix the shape of s_title => you forgot to remove the attribute from the "normal" snippet and you set the wrong one for the "configurator" one 😉

=> see diff

Note, I think that s_image_text_default_image is used too many times (3 identical images in the same pages seems too much) 😬 But we can fix it later when we will fix the svg and the fallback images 🙂

sobo-odoo
sobo-odoo approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@sobo-odoo sobo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

@sobo-odoo
Copy link
Contributor

@robodoo r-

@anso-odoo anso-odoo force-pushed the 18.0-theme_bookstore-post-merge-fixes-anso branch from df6362e to ab539c1 Compare October 1, 2024 11:08
@anso-odoo @sobo-odoo
[FIX] theme_bookstore: fix multiple issues in the theme
97473fc 
This commit fixes multiples issues in the theme:

- Wording
- Shapes that should appear only in the configurator
- Useless xpaths
- Font bug in Firefox (-> texts have been outlined in the svg)

task-4221731
@sobo-odoo sobo-odoo force-pushed the 18.0-theme_bookstore-post-merge-fixes-anso branch from ab539c1 to 97473fc Compare October 1, 2024 11:35
sobo-odoo
sobo-odoo approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@sobo-odoo sobo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobo-odoo sobo-odoo sobo-odoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anso-odoo @robodoo @sobo-odoo