[IMP] theme_*: adapt s_form_aside snippet across themes
#1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chgo-odoo
force-pushed
the
master-website-s_form_aside-chgo
branch
from
4d77565
to
61f15b4
Compare
mano-odoo
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Just a suggestion, aside from that LGTM 👼
Out of scope note: The assets in the themes for s_empowerment seems to use badly cropped images in many themes, displaying a weird white border on top and bottom of the image. Maybe we should consider a task to fix these assets with better images.
*: artists, nano, notes, vehicle This commit adapt the occurrences of the `s_form_aside` snippet across themes. task-4135499 part of task-4077427
chgo-odoo
force-pushed
the
master-website-s_form_aside-chgo
branch
from
61f15b4
to
4a65fbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*: artists, nano, notes, vehicle
This commit adapt the occurrences of the
s_form_asidesnippet acrossthemes.
task-4135499
part of task-4077427
s_form_asidesnippet. odoo#184094