Better-logging #140
Merged
Better-logging #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…similarly for main
…ng with the odilia-cache crate
most of it is only available at the trace level though, because they aren't informative enough when used in debug mode, compared to the noise they create
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 16.64% 19.50% +2.85%
==========================================
Files 22 23 +1
Lines 1646 1010 -636
==========================================
- Hits 274 197 -77
+ Misses 1372 813 -559 ☔ View full report in Codecov by Sentry. |
TTWNO
reviewed
Mar 12, 2024
| pub parent: CacheRef, | ||
| // The accessbile index in parent. i | ||
| /// The accessible index in parent.I |
There was a problem hiding this comment.
The last character is a DBus XML type definition. don't capitalize it.
| @@ -673,6 +688,7 @@ pub struct Cache { | |||
| impl Cache { | |||
| /// create a new, fresh cache | |||
| #[must_use] | |||
| #[tracing::instrument(level = "debug", ret)] | |||
| @@ -790,6 +815,7 @@ impl Cache { | |||
| /// 1. The `accessible` can not be turned into an `AccessiblePrimitive`. This should never happen, but is technically possible. | |||
| /// 2. The [`Self::add`] function fails. | |||
| /// 3. The [`accessible_to_cache_item`] function fails. | |||
| #[tracing::instrument(level = "debug", ret, err)] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add more spans and make logging generally a lot more useful