Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Display impl for State #205

Merged
merged 4 commits into from
Jun 29, 2024
Merged

Add Display impl for State #205

merged 4 commits into from
Jun 29, 2024

Conversation

TTWNO
Copy link
Member

@TTWNO TTWNO commented Jun 27, 2024

  • Use display instead of Into
  • Fix some formatting so that syntax highlighting is happy

Copy link
Collaborator

@luukvanderduim luukvanderduim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@luukvanderduim
Copy link
Collaborator

I just saw the clippy run error.
Easiest fix is to use State::from_str instead of into there, I think.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.93%. Comparing base (d8e2bdb) to head (ee2a44a).
Report is 3 commits behind head on main.

Files Patch % Lines
atspi-common/src/state.rs 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   86.95%   86.93%   -0.02%     
==========================================
  Files          40       40              
  Lines        3518     3528      +10     
==========================================
+ Hits         3059     3067       +8     
- Misses        459      461       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@DataTriny DataTriny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@TTWNO TTWNO merged commit f4ca3cc into main Jun 29, 2024
13 of 14 checks passed
@TTWNO TTWNO deleted the all-into-string-becomes-display branch June 29, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants